shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-09 01:18:39 +03:00
Code Releases Activity

Add fixmes

Browse Source 
There is missing some proper reaction when update fails ?
This commit is contained in:
Zdenek Kabelac 2012-03-23 10:34:51 +00:00
parent 963ccfd981
commit 4dd8a94a20
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
daemons/lvmetad/lvmetad-core.c
View File

@ -675,6 +675,7 @@ static int remove_metadata(lvmetad_state *s, const char *vgid, int update_pvids)
assert(oldname);
if (update_pvids)
/* FIXME: What should happen when update fails */
update_pvid_to_vgid(s, old, "#orphan", 0);
/* need to update what we have since we found a newer version */
dm_hash_remove(s->vgid_to_metadata, vgid);
@ -804,7 +805,8 @@ static int update_metadata(lvmetad_state *s, const char *name, const char *_vgid
unlock_vgid_to_metadata(s);
if (retval)
update_pvid_to_vgid(s, cft, vgid, 1);
/* FIXME: What should happen when update fails */
retval = update_pvid_to_vgid(s, cft, vgid, 1);
unlock_pvid_to_vgid(s);
out: