From 5042463c5083cc71546297344058bd0fa523aa5c Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Tue, 20 Jul 2021 22:28:13 +0200 Subject: [PATCH] vgremove: remove forgotten pmspare As pmspare is an invisible LV it's not getting automatically removed since vgremove removes only visible LVs and it depending LVs. If there was no other thin/cache pool volume, such pmspare stayed undeleted and caused command failure. So handle explicitelly such forgotten pmspare and remove it. --- tools/vgremove.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/vgremove.c b/tools/vgremove.c index 8f73297dc..b6685ae2a 100644 --- a/tools/vgremove.c +++ b/tools/vgremove.c @@ -65,6 +65,10 @@ static int _vgremove_single(struct cmd_context *cmd, const char *vg_name, } } + if (vg->pool_metadata_spare_lv && + !lvremove_single(cmd, vg->pool_metadata_spare_lv, &void_handle)) + return_ECMD_FAILED; + if (!lockd_free_vg_before(cmd, vg, 0)) return_ECMD_FAILED;