1
0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00

gcc-fanalyzer: explicit test null not pass

Make analyzer explicitelly aware we can't get NULL here.
This commit is contained in:
Zdenek Kabelac 2021-09-18 00:26:24 +02:00
parent e15d1e53c1
commit 5126ac7c3a
2 changed files with 9 additions and 1 deletions

View File

@ -657,6 +657,11 @@ static int _split_mirror_images(struct logical_volume *lv,
dm_list_add(&split_images, &lvl->list);
}
if (!new_lv) {
log_error(INTERNAL_ERROR "New LV not found.");
return 0;
}
new_lv->name = dm_pool_strdup(lv->vg->vgmem, split_name);
if (!new_lv->name) {
log_error("Unable to rename newly split LV.");

View File

@ -104,7 +104,10 @@ int vgcfgrestore(struct cmd_context *cmd, int argc, char **argv)
return ECMD_PROCESSED;
}
if (!_check_all_dm_devices(vg_name, &found)) {
if (!vg_name) {
log_error(INTERNAL_ERROR "VG name is not set.");
return ECMD_FAILED;
} else if (!_check_all_dm_devices(vg_name, &found)) {
log_warn("WARNING: Failed to check for active volumes in volume group \"%s\".", vg_name);
} else if (found) {
log_warn("WARNING: Found %u active volume(s) in volume group \"%s\".",