shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-22 17:35:59 +03:00
Code Releases Activity

Fix for bug 612291: dm devices of split off mirror images are not removed

Browse Source 
DM devices were not handled properly on nodes in a cluster that were not
where the splitmirrors command was issued.  This was happening because
suspend_lv/resume_lv were being used in a place where activate_lv should
have been used.

When the suspend/resume are issued on (effectively) new LVs, their
'resource' (UUID) is not located in the lv_hash.  Thus, both operations
turn into no-ops.  You can see this from the output of clvmd from one
of the remote nodes:
<snip>
do_suspend_lv, lock not already held
<snip>
do_resume_lv, lock not already held

'activate_lv' enjoins the other nodes in the cluster to process the lock
and activate the new LV.  clvmd output from remote node as follows:
do_lock_lv: resource 'zMseY7CBuO3Ty09vXlplPAHzD0Y0CovjrTdv0R1VcwggMwPdYhutHErRcwm5Nd2S', cmd = 0x19 LCK_LV_ACTIVATE (READ|LV|NONBLOCK), flags = 0x84 (DMEVENTD_MONITOR ), memlock = 1
sync_lock: 'zMseY7CBuO3Ty09vXlplPAHzD0Y0CovjrTdv0R1VcwggMwPdYhutHErRcwm5Nd2S' mode:1 flags=1
sync_lock: returning lkid 27b0001

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Reviewed-by: Petr Rockai <prockai@redhat.com>
This commit is contained in:
Jonathan Earl Brassow 2010-08-16 18:02:14 +00:00
parent 22ffec640d
commit 51e294c501
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.73 -
================================
Fix 'lvconvert --splitmirrors' in cluster operation.
Fix clvmd init script exit code when executed as non-root user.
Change default alignment of pe_start to 1MB.
Add --norestorefile option to pvcreate.

13
lib/metadata/mirror.c
View File

@ -719,19 +719,8 @@ static int _split_mirror_images(struct logical_volume *lv,
return 0;
}
/*
* Suspend the newly split-off LV (balance memlock count
* and prepare for DM automated renaming via resume).
*/
if (!suspend_lv(lv->vg->cmd, new_lv)) {
log_error("Failed to lock newly split LV, %s", new_lv->name);
vg_revert(lv->vg);
return 0;
}
/* Bring newly split-off LV into existence */
log_very_verbose("Creating %s", new_lv->name);
if (!resume_lv(lv->vg->cmd, new_lv)) {
if (!activate_lv(lv->vg->cmd, new_lv)) {
log_error("Failed to activate newly split LV, %s",
new_lv->name);
return 0;