shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-02 01:18:26 +03:00
Code Releases Activity

metadata: Factor _wipe_outdated_pvs() PVs out of _vg_read().

Browse Source
This commit is contained in:
Petr Rockai 2015-04-15 16:40:26 +02:00
parent 1562cd7320
commit 5435346052
1 changed files with 29 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
lib/metadata/metadata.c
View File

@ -3224,6 +3224,30 @@ static int _check_mda_in_use(struct metadata_area *mda, void *_in_use)
return 1; return 1;
} }
static int _wipe_outdated_pvs(struct cmd_context *cmd, struct volume_group *vg, struct dm_list *to_check)
{
struct pv_list *pvl, *pvl2;
char uuid[64] __attribute__((aligned(8)));
dm_list_iterate_items(pvl, to_check) {
dm_list_iterate_items(pvl2, &vg->pvs) {
if (pvl->pv->dev == pvl2->pv->dev)
goto next_pv;
}
if (!id_write_format(&pvl->pv->id, uuid, sizeof(uuid)))
return_0;
log_warn("WARNING: Removing PV %s (%s) that no longer belongs to VG %s",
pv_dev_name(pvl->pv), uuid, vg->name);
if (!pv_write_orphan(cmd, pvl->pv))
return_0;
/* Refresh metadata after orphan write */
drop_cached_metadata(vg);
next_pv:
;
}
return 1;
}
/* Caller sets consistent to 1 if it's safe for vg_read_internal to correct /* Caller sets consistent to 1 if it's safe for vg_read_internal to correct
* inconsistent metadata on disk (i.e. the VG write lock is held). * inconsistent metadata on disk (i.e. the VG write lock is held).
* This guarantees only consistent metadata is returned. * This guarantees only consistent metadata is returned.
@ -3257,9 +3281,8 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
int inconsistent_mda_count = 0; int inconsistent_mda_count = 0;
unsigned use_precommitted = precommitted; unsigned use_precommitted = precommitted;
struct dm_list *pvids; struct dm_list *pvids;
struct pv_list *pvl, *pvl2; struct pv_list *pvl;
struct dm_list all_pvs; struct dm_list all_pvs;
char uuid[64] __attribute__((aligned(8)));
unsigned seqno = 0; unsigned seqno = 0;
int reappeared = 0; int reappeared = 0;
struct cached_vg_fmtdata *vg_fmtdata = NULL; /* Additional format-specific data about the vg */ struct cached_vg_fmtdata *vg_fmtdata = NULL; /* Additional format-specific data about the vg */
@ -3684,28 +3707,10 @@ static struct volume_group *_vg_read(struct cmd_context *cmd,
return NULL; return NULL;
} }
dm_list_iterate_items(pvl, &all_pvs) { if (!_wipe_outdated_pvs(cmd, correct_vg, &all_pvs)) {
dm_list_iterate_items(pvl2, &correct_vg->pvs) { _free_pv_list(&all_pvs);
if (pvl->pv->dev == pvl2->pv->dev) release_vg(correct_vg);
goto next_pv; return_NULL;
}
if (!id_write_format(&pvl->pv->id, uuid, sizeof(uuid))) {
_free_pv_list(&all_pvs);
release_vg(correct_vg);
return_NULL;
}
log_warn("WARNING: Removing PV %s (%s) that no longer belongs to VG %s",
pv_dev_name(pvl->pv), uuid, correct_vg->name);
if (!pv_write_orphan(cmd, pvl->pv)) {
_free_pv_list(&all_pvs);
release_vg(correct_vg);
return_NULL;
}
/* Refresh metadata after orphan write */
drop_cached_metadata(correct_vg);
next_pv:
;
} }
} }