1
0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00

coverity: blkdeactivate: separate format and args for printf and declare and assign separately to avoid masking return values

This commit is contained in:
Peter Rajnoha 2016-05-31 09:39:06 +02:00
parent 02d67848eb
commit 5b3a4a9595

View File

@ -147,7 +147,7 @@ device_umount_one() {
if test -z "${SKIP_UMOUNT_LIST["$mnt"]}" -a "$DO_UMOUNT" -eq "1"; then
echo -n " [UMOUNT]: unmounting $name ($kname) mounted on $mnt... "
if eval $UMOUNT $UMOUNT_OPTS "$(printf $mnt)" $OUT $ERR; then
if eval $UMOUNT $UMOUNT_OPTS "$(printf "%s" "$mnt")" $OUT $ERR; then
echo "done"
else
echo "skipping"
@ -193,7 +193,8 @@ deactivate_holders () {
}
deactivate_dm () {
local name=$(printf $name)
local name
name=$(printf "%s" "$name")
test -b "$DEV_DIR/mapper/$name" || return 0
test -z ${SKIP_DEVICE_LIST["$kname"]} || return 1
@ -262,7 +263,8 @@ deactivate_lvm () {
}
deactivate_md () {
local name=$(printf $name)
local name
name=$(printf "%s" "$name")
test -b "$DEV_DIR/$name" || return 0
test -z ${SKIP_DEVICE_LIST["$kname"]} || return 1