shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

lvchange: reject setting all raid1 images to writemostly

Browse Source 
raid1 doesn't allow to set all images to writemostly because at
least one image is required to receive any written data immediately.

The dm-raid target will detect such invalid request and
fail it iwith a kernel error message.

Reject such request in uspace displaying a respective error message.
This commit is contained in:
Heinz Mauelshagen 2017-03-26 20:28:04 +02:00
parent 5c199d99f4
commit 6165e09221
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tools/lvchange.c
View File

@ -732,7 +732,8 @@ static int _lvchange_rebuild(struct logical_volume *lv)
static int _lvchange_writemostly(struct logical_volume *lv) static int _lvchange_writemostly(struct logical_volume *lv)
{ {
int s, pv_count, i = 0; int pv_count, i = 0;
uint32_t s, writemostly;
char **pv_names; char **pv_names;
const char *tmp_str; const char *tmp_str;
size_t tmp_str_len; size_t tmp_str_len;
@ -808,7 +809,7 @@ static int _lvchange_writemostly(struct logical_volume *lv)
return 0; return 0;
} }
for (s = 0; s < (int) raid_seg->area_count; s++) { for (s = 0; s < raid_seg->area_count; s++) {
/* /*
* We don't bother checking the metadata area, * We don't bother checking the metadata area,
* since writemostly only affects the data areas. * since writemostly only affects the data areas.
@ -830,6 +831,19 @@ static int _lvchange_writemostly(struct logical_volume *lv)
return_0; return_0;
} }
} }
}
/* Only allow a maximum on N-1 images to be set writemostly. */
writemostly = 0;
for (s = 0; s < raid_seg->area_count; s++)
if (seg_lv(raid_seg, s)->status & LV_WRITEMOSTLY)
writemostly++;
if (writemostly == raid_seg->area_count) {
log_error("Can't set all images of %s LV %s to writemostly.",
lvseg_name(raid_seg), display_lvname(lv));
return 0;
} }
} }