shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cov: check for valid raid0 LV segment

Browse Source 
Add internal error to quiet Coverity fear of NULL pointer deref.
This commit is contained in:
Zdenek Kabelac 2024-05-04 12:38:13 +02:00
parent 099a4e2146
commit 61a11f25a3
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/metadata/raid_manip.c
View File

@ -4409,6 +4409,7 @@ static struct lv_segment *_convert_striped_to_raid0(struct logical_volume *lv,
struct lv_segment *seg, *raid0_seg;
struct segment_type *segtype;
struct dm_list data_lvs;
struct lv_list *l;
dm_list_iterate_items(seg, &lv->segments)
area_len += seg->area_len;
@ -4452,7 +4453,12 @@ static struct lv_segment *_convert_striped_to_raid0(struct logical_volume *lv,
* areas based on the first data LVs properties derived
* from the first new raid0 LVs first segment
*/
seg = first_seg(dm_list_item(dm_list_first(&data_lvs), struct lv_list)->lv);
if (!(l = dm_list_item(dm_list_first(&data_lvs), struct lv_list))) {
log_error(INTERNAL_ERROR "Invalid data lvs for raid0 LV %s.",
display_lvname(lv));
return NULL;
}
seg = first_seg(l->lv);
if (!(raid0_seg = alloc_lv_segment(segtype, lv,
0 /* le */, lv->le_count /* len */,
0, 0,