shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

thin: deactivate converted volume early

Browse Source 
Deactivate converted volume to pool early, so the conversion
exits early and does not leave some already created metadata
volumes that needed manual cleanup by user after command
aborted its conversion operation when the converted volume
was actually in-use  (i.e. when user tried to convert
a mounted LV into a thin-pool, 2 extra volumes needed removal).
This commit is contained in:
Zdenek Kabelac 2024-12-19 14:47:16 +01:00
parent 928b8e9c6e
commit 6326d00937
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tools/lvconvert.c
View File

@ -3154,6 +3154,13 @@ static int _lvconvert_to_pool(struct cmd_context *cmd,
activate_pool = to_thinpool && is_active;
/* Before the conversion starts, make sure the volume is unused and can be deactivated
* (as it needs to change target type) */
if (is_active && !to_thin && !deactivate_lv(cmd, lv)) {
log_error("Cannot convert logical volume %s.", display_lvname(lv));
return 0;
}
/* Wipe metadata_lv by default, but allow skipping this for cache pools. */
zero_metadata = (to_cachepool) ? arg_int_value(cmd, zero_ARG, 1) : 1;
@ -3405,13 +3412,6 @@ static int _lvconvert_to_pool(struct cmd_context *cmd,
if (!(pool_lv = _lvconvert_insert_thin_layer(lv)))
goto_bad;
} else {
/* Deactivate the data LV (changing target type) */
if (!deactivate_lv(cmd, lv)) {
log_error("Aborting. Failed to deactivate logical volume %s.",
display_lvname(lv));
goto bad;
}
if (data_vdo) {
if (lv_is_vdo(lv)) {
if ((seg = first_seg(lv)))