1
0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00

Fix memory lock imbalance in lv_suspend if already suspended.

pvmove suspends all moved LVs + pvmoveX mirrored LV itself.

This suspends even underlying pvmoveX and following explicit
suspend call is just noop.

But in resume the pvmoveX volume is no longer underlying
device for moved LVs, so it performs full resume with memlock
decrease.

Code must call memlock_inc() if suspend is requested, volume
is already suspended and error is not requested.
This commit is contained in:
Milan Broz 2009-12-03 19:23:40 +00:00
parent 29f011314d
commit 63ae0d1464
2 changed files with 6 additions and 1 deletions

View File

@ -1,5 +1,6 @@
Version 2.02.57 -
====================================
Fix memory lock imbalance in lv_suspend if already suspended.
Fix pvmove test mode to not fail and do not poll.
Fix error message if VG already exist in vgcreate.
Fix tools to use log_error when stopped by user.

View File

@ -879,7 +879,11 @@ static int _lv_suspend(struct cmd_context *cmd, const char *lvid_s,
goto_out;
if (!info.exists || info.suspended) {
r = error_if_not_suspended ? 0 : 1;
if (!error_if_not_suspended) {
r = 1;
if (info.suspended)
memlock_inc();
}
goto out;
}