From 65bbfdf74ddbb16579c4fa5fc76e1f51aee0da22 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Tue, 25 Mar 2014 14:53:06 +0100 Subject: [PATCH] lvmetad: add missing dev_close in error path Fixes missing dev_close() in dev_read error path introduced in commit a36869867275b8ef0f6d324bc5a7f3e2b8e445e9 3e5bec37e9cec455f20656858ba510b69010676d (in-release fix) --- lib/format_text/format-text.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/format_text/format-text.c b/lib/format_text/format-text.c index c987cd67a..a1f4a676d 100644 --- a/lib/format_text/format-text.c +++ b/lib/format_text/format-text.c @@ -321,8 +321,10 @@ static int _raw_read_mda_header(struct mda_header *mdah, struct device_area *dev if (!dev_open_readonly(dev_area->dev)) return_0; - if (!dev_read(dev_area->dev, dev_area->start, MDA_HEADER_SIZE, mdah)) + if (!dev_read(dev_area->dev, dev_area->start, MDA_HEADER_SIZE, mdah)) { + (void) dev_close(dev_area->dev); return_0; + } if (!dev_close(dev_area->dev)) return_0;