From 67b4761bc3c53ee67a1fbe33f41757a6563db5cb Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Mon, 9 Nov 2015 09:47:21 +0100 Subject: [PATCH] toollib: add missing check for lvmcache_init() Coverity notices lvmcache_init() may fail so check and error out in case of failure. --- tools/toollib.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/toollib.c b/tools/toollib.c index 42ac71a13..a52252e97 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -3181,7 +3181,11 @@ int process_each_pv(struct cmd_context *cmd, log_verbose("Some PVs were not found in first search, retrying."); lvmcache_destroy(cmd, 0, 0); - lvmcache_init(); + if (!lvmcache_init()) { + log_error("Failed to initalize lvm cache."); + ret_max = ECMD_FAILED; + goto out; + } lvmcache_seed_infos_from_lvmetad(cmd); ret = _process_pvs_in_vgs(cmd, read_flags, &all_vgnameids, &all_devices,