shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-28 02:50:41 +03:00
Code Releases Activity

Ensure right activation order

Browse Source 
Couple FIXMEs put into the code for parts of the code which may be
improved later, since we might be able to add 'lazy' device creation later.
For now require exclusive activation.
This commit is contained in:
Zdenek Kabelac 2011-10-20 10:35:14 +00:00
parent bc8bfff5ff
commit 692d718d9d
1 changed files with 29 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
lib/metadata/lv_manip.c
View File

@ -4214,7 +4214,33 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l
init_dmeventd_monitor(lp->activation_monitoring);
if (lp->snapshot) {
if (seg_is_thin_pool(lp)) {
/* FIXME: skipping in test mode is not going work */
if (!activate_lv_excl(cmd, first_seg(lv)->pool_metadata_lv) ||
/* First 4KB of metadata device must be cleared. */
!set_lv(cmd, first_seg(lv)->pool_metadata_lv, UINT64_C(0), 0)) {
log_error("Aborting. Failed to wipe pool metadata %s.",
lv->name);
goto revert_new_lv;
}
/* FIXME: we may postpone finish of the pool creation to the
* moment of the first activation - but this needs more changes
* so we would update metadata with vgchange -ay
*
* For now always activate.
*/
if (!activate_lv_excl(cmd, lv)) {
log_error("Aborting. Could not to activate thin pool %s.",
lv->name);
goto revert_new_lv;
}
} else if (seg_is_thin(lp)) {
/* FIXME: same as with thin pool - add lazy creation support */
if (!activate_lv_excl(cmd, lv)) {
log_error("Aborting. Failed to activate thin %s.", lv->name);
goto revert_new_lv;
}
} else if (lp->snapshot) {
if (!activate_lv_excl(cmd, lv)) {
log_error("Aborting. Failed to activate snapshot "
"exception store.");
@ -4236,12 +4262,9 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l
lp->snapshot ? "snapshot exception store" :
"start of new LV");
goto deactivate_and_revert_new_lv;
} else if (seg_is_thin_pool(lp)) {
if (!set_lv(cmd, first_seg(lv)->pool_metadata_lv, UINT64_C(0), 0))
log_error("Aborting. Failed to wipe pool metadata %s.",
lv->name);
} else if (seg_is_thin_volume(lp)) {
/* since we've got here, we may drop any queued thin messages */
/* FIXME: for now we may drop any queued thin messages
* since we are sure everything was activated already */
if (!detach_pool_messages(first_seg(first_seg(lv)->pool_lv)))
goto deactivate_and_revert_new_lv;