1
0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-03 05:18:29 +03:00

Remove unused internal non-persistent snapshot option.

This commit is contained in:
Alasdair Kergon 2005-04-07 12:27:57 +00:00
parent 0c86ac44a9
commit 69b2cc0ee0
6 changed files with 6 additions and 7 deletions

View File

@ -1,6 +1,7 @@
Version 2.01.10 - Version 2.01.10 -
================================ ================================
Internal snapshot restructuring. Internal snapshot restructuring.
Remove unused internal non-persistent snapshot option.
Allow offline extension of snapshot volumes. Allow offline extension of snapshot volumes.
Move from 2-step to 3-step on-disk metadata commit. Move from 2-step to 3-step on-disk metadata commit.
Scan ramdisks too and allow non-O_DIRECT fallback. Scan ramdisks too and allow non-O_DIRECT fallback.

View File

@ -646,7 +646,7 @@ int import_snapshots(struct pool *mem, struct volume_group *vg,
continue; continue;
/* insert the snapshot */ /* insert the snapshot */
if (!vg_add_snapshot(org, cow, 1, NULL, org->le_count, if (!vg_add_snapshot(org, cow, NULL, org->le_count,
lvd->lv_chunk_size)) { lvd->lv_chunk_size)) {
log_err("Couldn't add snapshot."); log_err("Couldn't add snapshot.");
return 0; return 0;

View File

@ -260,7 +260,6 @@ struct logical_volume {
struct snapshot { struct snapshot {
union lvid lvid; union lvid lvid;
int persistent; /* boolean */
uint32_t chunk_size; /* in 512 byte sectors */ uint32_t chunk_size; /* in 512 byte sectors */
uint32_t le_count; uint32_t le_count;
@ -508,7 +507,7 @@ struct snapshot *find_origin(const struct logical_volume *lv);
struct list *find_snapshots(const struct logical_volume *lv); struct list *find_snapshots(const struct logical_volume *lv);
int vg_add_snapshot(struct logical_volume *origin, struct logical_volume *cow, int vg_add_snapshot(struct logical_volume *origin, struct logical_volume *cow,
int persistent, union lvid *lvid, uint32_t extent_count, union lvid *lvid, uint32_t extent_count,
uint32_t chunk_size); uint32_t chunk_size);
int vg_remove_snapshot(struct volume_group *vg, struct logical_volume *cow); int vg_remove_snapshot(struct volume_group *vg, struct logical_volume *cow);

View File

@ -105,7 +105,7 @@ struct list *find_snapshots(const struct logical_volume *lv)
} }
int vg_add_snapshot(struct logical_volume *origin, struct logical_volume *cow, int vg_add_snapshot(struct logical_volume *origin, struct logical_volume *cow,
int persistent, union lvid *lvid, uint32_t extent_count, union lvid *lvid, uint32_t extent_count,
uint32_t chunk_size) uint32_t chunk_size)
{ {
struct snapshot *s; struct snapshot *s;
@ -125,7 +125,6 @@ int vg_add_snapshot(struct logical_volume *origin, struct logical_volume *cow,
return 0; return 0;
} }
s->persistent = persistent;
s->chunk_size = chunk_size; s->chunk_size = chunk_size;
s->le_count = extent_count; s->le_count = extent_count;
s->origin = origin; s->origin = origin;

View File

@ -70,7 +70,7 @@ static int _text_import(struct lv_segment *seg, const struct config_node *sn,
return 0; return 0;
} }
if (!vg_add_snapshot(org, cow, 1, &seg->lv->lvid, seg->len, if (!vg_add_snapshot(org, cow, &seg->lv->lvid, seg->len,
chunk_size)) { chunk_size)) {
stack; stack;
return 0; return 0;

View File

@ -609,7 +609,7 @@ static int _lvcreate(struct cmd_context *cmd, struct lvcreate_params *lp)
return 0; return 0;
} }
if (!vg_add_snapshot(org, lv, 1, NULL, org->le_count, if (!vg_add_snapshot(org, lv, NULL, org->le_count,
lp->chunk_size)) { lp->chunk_size)) {
log_err("Couldn't create snapshot."); log_err("Couldn't create snapshot.");
return 0; return 0;