shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Improve logging for setting --vgmetadatacopies.

Browse Source 
Example of logging:
metadata/metadata.c:1127     Setting mda_copies = 3 on vg vgtest
metadata/pv_manip.c:296         /dev/loop2 0:      0     25: NULL(0:0)
metadata/pv_manip.c:296         /dev/loop3 0:      0     25: NULL(0:0)
metadata/pv_manip.c:296         /dev/loop4 0:      0     25: NULL(0:0)
metadata/metadata.c:1072     Adjusting ignored mdas on vg vgtest, vg_mda_used_count=5, vg_mda_copies=3
metadata/metadata.c:1015     Setting ignore flag for 2 mdas on vg vgtest
metadata/metadata.c:4151     Setting mda ignored flag for metadata_locn /dev/loop2.
metadata/metadata.c:4151     Setting mda ignored flag for metadata_locn /dev/loop3.
This commit is contained in:
Dave Wysochanski 2010-06-29 22:41:28 +00:00
parent d37dd5b2d3
commit 6af5155529
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/metadata/metadata-exported.h
View File

@ -886,7 +886,7 @@ uint32_t vg_mda_used_count(const struct volume_group *vg);
#define VGMETADATACOPIES_ALL UINT32_MAX #define VGMETADATACOPIES_ALL UINT32_MAX
#define VGMETADATACOPIES_UNMANAGED 0 #define VGMETADATACOPIES_UNMANAGED 0
uint32_t vg_mda_copies(const struct volume_group *vg); uint32_t vg_mda_copies(const struct volume_group *vg);
int vg_set_mda_copies(struct volume_group *vg, uint32_t value); int vg_set_mda_copies(struct volume_group *vg, uint32_t copies);
int vg_check_write_mode(struct volume_group *vg); int vg_check_write_mode(struct volume_group *vg);
#define vg_is_clustered(vg) (vg_status((vg)) & CLUSTERED) #define vg_is_clustered(vg) (vg_status((vg)) & CLUSTERED)
#define vg_is_exported(vg) (vg_status((vg)) & EXPORTED_VG) #define vg_is_exported(vg) (vg_status((vg)) & EXPORTED_VG)

13
lib/metadata/metadata.c
View File

@ -1011,6 +1011,8 @@ static int _vg_ignore_mdas(struct volume_group *vg, uint32_t num_to_ignore)
{ {
struct metadata_area *mda; struct metadata_area *mda;
log_verbose("Setting ignore flag for %"PRIu32" mdas on vg %s",
num_to_ignore, vg->name);
if (!num_to_ignore) if (!num_to_ignore)
return 1; return 1;
/* FIXME: flip bits on random mdas */ /* FIXME: flip bits on random mdas */
@ -1031,6 +1033,8 @@ static int _vg_unignore_mdas(struct volume_group *vg, uint32_t num_to_unignore)
{ {
struct metadata_area *mda, *tmda; struct metadata_area *mda, *tmda;
log_verbose("Clearing ignore flag for %"PRIu32" mdas on vg %s",
num_to_unignore, vg->name);
if (!num_to_unignore) if (!num_to_unignore)
return 1; return 1;
/* FIXME: flip bits on random mdas */ /* FIXME: flip bits on random mdas */
@ -1063,6 +1067,9 @@ static int _vg_adjust_ignored_mdas(struct volume_group *vg)
int ret = 1; int ret = 1;
mda_copies = vg_mda_used_count(vg); mda_copies = vg_mda_used_count(vg);
log_verbose("Adjusting ignored mdas on vg %s, vg_mda_used_count=%"
PRIu32", vg_mda_copies=%"PRIu32,
vg->name, mda_copies, vg_mda_copies(vg));
if (vg->mda_copies == VGMETADATACOPIES_UNMANAGED) if (vg->mda_copies == VGMETADATACOPIES_UNMANAGED)
goto skip_adjust; goto skip_adjust;
@ -1108,14 +1115,16 @@ uint32_t vg_mda_copies(const struct volume_group *vg)
return vg->mda_copies; return vg->mda_copies;
} }
int vg_set_mda_copies(struct volume_group *vg, uint32_t value) int vg_set_mda_copies(struct volume_group *vg, uint32_t copies)
{ {
/* FIXME: add checks, etc, and set the value */ /* FIXME: add checks, etc, and set the value */
/* /*
* FIXME: Before we set a larger value, we may need to * FIXME: Before we set a larger value, we may need to
* enable some mdas on PVS * enable some mdas on PVS
*/ */
vg->mda_copies = value; vg->mda_copies = copies;
log_verbose("Setting mda_copies = %"PRIu32" on vg %s",
copies, vg->name);
return 1; return 1;
} }