shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-02-25 21:57:45 +03:00
Code Releases Activity

Remove LOCK_KEEP and READ_CHECK_EXISTENCE from vgsplit.

Browse Source 
Remove LOCK_KEEP and READ_CHECK_EXISTENCE from vgsplit.
These flags are no longer necessary.  We now check for existence
in a differnet function, and it is not necessary to keep the lock.
Removing these flags simplifies the new vg_read() interface.
After this patch, we can fully remove LOCK_KEEP.
READ_CHECK_EXISTENCE needs a bit more work before full removal.

Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
This commit is contained in:
Dave Wysochanski 2009-07-08 14:27:37 +00:00
parent dd1d42d5d0
commit 6b6f59da79
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/vgsplit.c
View File

@ -342,11 +342,13 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
existing_vg = 1;
vg_to = vg_read_for_update(cmd, vg_name_to, NULL,
READ_REQUIRE_RESIZEABLE |
LOCK_NONBLOCKING | LOCK_KEEP |
READ_CHECK_EXISTENCE);
LOCK_NONBLOCKING);
if (vg_read_error(vg_to))
goto_bad;
if (vg_read_error(vg_to)) {
vg_release(vg_to);
stack;
goto bad2;
}
if (new_vg_option_specified(cmd)) {
log_error("Volume group \"%s\" exists, but new VG "
@ -483,7 +485,8 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
r = ECMD_PROCESSED;
bad:
unlock_and_release_vg(cmd, vg_from, vg_name_from);
unlock_and_release_vg(cmd, vg_to, vg_name_to);
bad2:
unlock_and_release_vg(cmd, vg_from, vg_name_from);
return r;
}