shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cov: check for possible NULL segtype

Browse Source 
Although likely impossible to ever miss ERROR segtype,
make analyzer hapier.
This commit is contained in:
Zdenek Kabelac 2021-09-20 01:51:29 +02:00
parent bfc6fe2bac
commit 6c87e98ee3
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/metadata/lv_manip.c
View File

@ -1699,6 +1699,10 @@ int lv_empty(struct logical_volume *lv)
int replace_lv_with_error_segment(struct logical_volume *lv)
{
uint32_t len = lv->le_count;
struct segment_type *segtype;
if (!(segtype = get_segtype_from_string(lv->vg->cmd, SEG_TYPE_NAME_ERROR)))
return_0;
if (len && !lv_empty(lv))
return_0;
@ -1717,7 +1721,7 @@ int replace_lv_with_error_segment(struct logical_volume *lv)
/* FIXME Check for any attached LVs that will become orphans e.g. mirror logs */
if (!lv_add_virtual_segment(lv, 0, len, get_segtype_from_string(lv->vg->cmd, SEG_TYPE_NAME_ERROR)))
if (!lv_add_virtual_segment(lv, 0, len, segtype))
return_0;
return 1;