shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-10-27 01:55:10 +03:00
Code Releases Activity

This patch fixes a problem where the mirror polling process

Browse Source 
may never complete.

If you convert from a linear to a mirror and then convert that
mirror back to linear /while/ the previous (up)convert is
taking place, the mirror polling process will never complete.
This is because the function that polls the mirror for
completion doesn't check if it is still polling a mirror and
the copy_percent that it gets back from the linear device is
certainly never 100%.

The fix is simply to check if the daemon is still looking at
a mirror device - if not, return PROGRESS_CHECK_FAILED.

The user sees the following output from the first (up)convert
if someone else sneaks in and does a down-convert shortly
after their convert:
[root@bp-01 ~]# lvconvert -m1 vg/lv
  vg/lv: Converted: 43.4%
  ABORTING: Mirror percentage check failed.
This commit is contained in:
Jonathan Earl Brassow 2010-08-26 16:29:12 +00:00
parent a71d6051ed
commit 6ec8c52201
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.74 - Version 2.02.74 -
================================== ==================================
Make poll_mirror_progress report PROGRESS_CHECK_FAILED if LV is not a mirror.
Like mirrors, don't scan origins if ignore_suspended_devices() is set. Like mirrors, don't scan origins if ignore_suspended_devices() is set.
Fix return type qualifier to avoid compiler warning. (2.02.69) Fix return type qualifier to avoid compiler warning. (2.02.69)
Automatically generate LSB Requires-Start for clvmd init script. Automatically generate LSB Requires-Start for clvmd init script.

3
tools/polldaemon.c
View File

@ -78,7 +78,8 @@ progress_t poll_mirror_progress(struct cmd_context *cmd,
percent_range_t percent_range, overall_percent_range; percent_range_t percent_range, overall_percent_range;
uint32_t event_nr = 0; uint32_t event_nr = 0;
if (!lv_mirror_percent(cmd, lv, !parms->interval, &segment_percent, if (!lv_is_mirrored(lv) ||
!lv_mirror_percent(cmd, lv, !parms->interval, &segment_percent,
&percent_range, &event_nr) || &percent_range, &event_nr) ||
(percent_range == PERCENT_INVALID)) { (percent_range == PERCENT_INVALID)) {
log_error("ABORTING: Mirror percentage check failed."); log_error("ABORTING: Mirror percentage check failed.");