From 6f2a617c318d3e7b4535563b72ddcaad67da62ed Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Thu, 18 Jun 2015 14:38:05 +0200 Subject: [PATCH] thin: drop limitation for extension of reduced thin volume Drop check which has prevented resize of reduce thin volume with external origin. User is supposed to use 'zeroing' to get 'clean' chunks. --- WHATS_NEW | 1 + lib/metadata/lv_manip.c | 10 ---------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 9e2a3ddd9..42a2571a7 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.122 - ================================= + Allow to extend reduced thin volumes with external origins. Consider snapshot and origin LV as unusable if its component is suspended. Fix lvmconfig segfault on settings with undefined default value (2.02.120). diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index 998379381..07f119a44 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -5084,16 +5084,6 @@ static int _lvresize_check_type(struct cmd_context *cmd, const struct logical_vo if (lv_is_thin_volume(lv) && first_seg(lv)->external_lv && (lp->resize == LV_EXTEND)) { - /* - * TODO: currently we do not support extension of already reduced thin volume. - * But it might be possible to create combined mapping of some part of - * the external origin followed by zero target. - */ - if (first_seg(lv)->external_lv->size > lv->size) { - log_error("Extension of reduced thin volume with external origin is unsupported."); - return 0; - } - /* Validate thin target supports bigger size of thin volume then external origin */ if (first_seg(lv)->external_lv->size <= lv->size && !thin_pool_feature_supported(first_seg(lv)->pool_lv, THIN_FEATURE_EXTERNAL_ORIGIN_EXTEND)) {