From 7232458b6c114cc83b471f08abc49fd1673831c4 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Tue, 25 Jun 2019 15:21:46 +0200 Subject: [PATCH] cov: validate pagesize is not negative As _init_free_list() cannot accept negative numbers --- lib/device/bcache.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/device/bcache.c b/lib/device/bcache.c index dac8be64d..ccf0046ba 100644 --- a/lib/device/bcache.c +++ b/lib/device/bcache.c @@ -1040,6 +1040,11 @@ struct bcache *bcache_create(sector_t block_sectors, unsigned nr_cache_blocks, unsigned max_io = engine->max_io(engine); long pgsize = sysconf(_SC_PAGESIZE); + if ((pgsize = sysconf(_SC_PAGESIZE)) < 0) { + log_warn("bcache cannot read pagesize."); + return NULL; + } + if (!nr_cache_blocks) { log_warn("bcache must have at least one cache block"); return NULL;