shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

activation: continue with autoactivation if refresh fails

Browse Source 
If the refresh fails for any reason before autoactivation, let's not
make this a stopper for autoactivation itself - just log the error
message if it appears.

The reason is that in some rare situations, we can still hit the
problem with the suspend call to fail (as already described in
commit d8085edf65, also
https://bugzilla.redhat.com/show_bug.cgi?id=1027314). The refresh
itself is done for only one reason - to refresh any dm tables
for LVs for which the underlying PVs got unplugged/disconnected
and then plugged/connected back (see also
https://bugzilla.redhat.com/show_bug.cgi?id=954061 for more info).
In this case, the major:minor pair is changed and we need to
update dm tables for LVs accordingly.

Now if refresh fails, the error is still logged, but autoactivation
continues.
This commit is contained in:
Peter Rajnoha 2013-11-27 08:20:02 +01:00
parent 8d5cff5b9b
commit 729b104413
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/pvscan.c
View File

@ -147,10 +147,8 @@ static int _auto_activation_handler(struct cmd_context *cmd,
usleep(REFRESH_BEFORE_AUTOACTIVATION_RETRY_USLEEP_DELAY); usleep(REFRESH_BEFORE_AUTOACTIVATION_RETRY_USLEEP_DELAY);
} }
if (!refresh_done) { if (!refresh_done)
log_error("%s: refresh before autoactivation failed.", vg->name); log_error("%s: refresh before autoactivation failed.", vg->name);
goto out;
}
if (!vgchange_activate(vg->cmd, vg, activate)) { if (!vgchange_activate(vg->cmd, vg, activate)) {
log_error("%s: autoactivation failed.", vg->name); log_error("%s: autoactivation failed.", vg->name);