shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-02-28 05:57:49 +03:00
Code Releases Activity

Move init_test() from _apply_settings into _init_logging().

Browse Source 
This one we actually need to move.  _init_logging() is called from
    create_toolcontext(), which makes this call:
        /* Test mode */
        cmd->default_settings.test =
            find_config_tree_int(cmd, "global/test", 0);

But it does not call init_test().  So we need an init_test() somewhere.
The most logical place is to put it inside _init_logging(), since this
is where the config value is read and default_settings are set.  Placing
the init_test() call here matches what is done with other variables and
seems to make sense.
This commit is contained in:
Dave Wysochanski 2008-12-11 03:31:47 +00:00
parent b14f29b5b7
commit 76d734a4bd
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/commands/toolcontext.c
View File

@ -162,6 +162,7 @@ static void _init_logging(struct cmd_context *cmd)
/* Test mode */
cmd->default_settings.test =
find_config_tree_int(cmd, "global/test", 0);
init_test(cmd->default_settings.test);
/* Settings for logging to file */
if (find_config_tree_int(cmd, "log/overwrite", DEFAULT_OVERWRITE))

1
tools/lvmcmdline.c
View File

@ -1091,7 +1091,6 @@ struct cmd_context *init_lvm(unsigned is_static)
if (!(cmd = create_toolcontext(_cmdline.the_args, is_static, 0)))
return_NULL;
init_test(cmd->current_settings.test);
init_full_scan_done(0);
init_mirror_in_sync(0);