shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Revert "libdm: trace missing settings"

Browse Source 
This reverts commit 8fd886f735.

This was a deliberate omission because logging token-by-token metadata
parsing greatly increases the amount of logging for hardly any benefit.

In general, only LVM config file settings need to be logged, and in
places where it's considered important to log particular elements of
metadata that should be done using specific log_* lines.

This area can be revisited.
This commit is contained in:
Alasdair G Kergon 2016-05-27 14:35:11 +01:00
parent b762c37555
commit 780424639a
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW_DM
View File

@ -12,7 +12,6 @@ Version 1.02.124 - 30th April 2016
Version 1.02.123 - 23rd April 2016
==================================
Trace more settings in very verbose mode for libdm-config.
Do not strip LVM- when debug reporting not found uuid.
Version 1.02.122 - 9th April 2016

15
libdm/libdm-config.c
View File

@ -1154,11 +1154,8 @@ int dm_config_get_uint32(const struct dm_config_node *cn, const char *path,
if (!n || !n->v || n->v->type != DM_CFG_INT)
return 0;
if (result) {
log_very_verbose("Setting %s to %u", path, (uint32_t) n->v->v.i);
if (result)
*result = n->v->v.i;
}
return 1;
}
@ -1172,11 +1169,8 @@ int dm_config_get_uint64(const struct dm_config_node *cn, const char *path,
if (!n || !n->v || n->v->type != DM_CFG_INT)
return 0;
if (result) {
log_very_verbose("Setting %s to " FMTu64 , path, (uint64_t) n->v->v.i);
if (result)
*result = (uint64_t) n->v->v.i;
}
return 1;
}
@ -1190,11 +1184,8 @@ int dm_config_get_str(const struct dm_config_node *cn, const char *path,
if (!n || !n->v || n->v->type != DM_CFG_STRING)
return 0;
if (result) {
log_very_verbose("Setting %s to %s", path, n->v->v.str);
if (result)
*result = n->v->v.str;
}
return 1;
}