shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-30 01:47:56 +03:00
Code Releases Activity

archiver: add check for dm_pool_strdup

Browse Source 
It will likely not fail to duplicate empty string, but
just keep the test of result of this function consistent.

Also on error path restore extent_size if in some
case someone would still use that variable.
This commit is contained in:
Zdenek Kabelac 2013-11-22 13:12:35 +01:00
parent d079c81ab4
commit 782a356e7c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/format_text/archiver.c
View File

@ -334,13 +334,17 @@ int backup_restore_vg(struct cmd_context *cmd, struct volume_group *vg, int drop
* Setting vg->old_name to a blank value will explicitly
* disable any attempt to check VG name in existing metadata.
*/
vg->old_name = dm_pool_strdup(vg->vgmem, "");
if (!(vg->old_name = dm_pool_strdup(vg->vgmem, ""))) {
log_error("Failed to duplicate empty name.");
return 0;
}
/* Add any metadata areas on the PVs */
dm_list_iterate_items(pvl, &vg->pvs) {
tmp = vg->extent_size;
vg->extent_size = 0;
if (!vg->fid->fmt->ops->pv_setup(vg->fid->fmt, pvl->pv, vg)) {
vg->extent_size = tmp;
log_error("Format-specific setup for %s failed",
pv_dev_name(pvl->pv));
return 0;