shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

pvscan: ignore device with incorrect size

Browse Source 
If a device looks like a PV, but its size does not
match the PV size in the metadata, then skip it for
purposes of autoactivation.  It's probably not wrong
device for the PV.
This commit is contained in:
David Teigland 2019-04-05 16:44:00 -05:00
parent 6f18186bfd
commit 7836e7aa1c
1 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
tools/pvscan.c
View File

@ -624,6 +624,36 @@ static int _online_pvscan_one(struct cmd_context *cmd, struct device *dev,
return 1;
}
/*
* Do not consider a device online (for purposes of autoactivation)
* if its size does not match the PV size recorded in the metadata.
* It may mean that it's not the correct dev for the PV, e.g. it
* could be an md component device that's not been filtered.
*/
if (baton.vg && cmd->check_pv_dev_sizes) {
struct pv_list *pvl;
uint64_t dev_size = 0;
uint64_t meta_pv_size = 0;
dm_list_iterate_items(pvl, &baton.vg->pvs) {
if (pvl->pv->dev != dev)
continue;
if (!dev_get_size(dev, &dev_size))
stack;
meta_pv_size = pv_size(pvl->pv);
break;
}
if (dev_size != meta_pv_size) {
log_print("pvscan[%d] PV %s ignore for size %llu not matching device %llu.",
getpid(), dev_name(dev),
(unsigned long long)meta_pv_size, (unsigned long long)dev_size);
release_vg(baton.vg);
return 1;
}
}
ret = _online_pv_found(cmd, dev, dev_args, baton.vg, found_vgnames);
release_vg(baton.vg);