From 79121416dfd695900a02711e6f63146e532b825b Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Sun, 18 Dec 2016 15:06:12 +0100 Subject: [PATCH] thin: add comment with future extension It could be actually better to use even cache origin in read-only mode so there could no be some 'acidental' change being done on this volume. This however need further tools enhancment - where we would need to handle whole subtree on 'lvchange -pr/-prw'. --- lib/metadata/thin_manip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/metadata/thin_manip.c b/lib/metadata/thin_manip.c index e7a2c33e3..42ec552d7 100644 --- a/lib/metadata/thin_manip.c +++ b/lib/metadata/thin_manip.c @@ -99,6 +99,10 @@ int attach_thin_external_origin(struct lv_segment *seg, external_lv->name); external_lv->status &= ~LVM_WRITE; } + + // TODO: should we mark even origin read-only ? + //if (lv_is_cache(external_lv)) /* read-only corigin of cache LV */ + // seg_lv(first_seg(external_lv), 0)->status &= ~LVM_WRITE; } return 1;