shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cleanup: use stack for small buffer

Browse Source 
Avoid error checking of allocation error when just few bytes are needed
for short string and use stack.
Stacktrace lvmetad_pv_gone() fail path.
This commit is contained in:
Zdenek Kabelac 2014-06-16 12:38:14 +02:00
parent 494db11004
commit 7aef45f9bb
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tools/pvscan.c
View File

@ -164,18 +164,15 @@ out:
static int _clear_dev_from_lvmetad_cache(dev_t devno, int32_t major, int32_t minor,
activation_handler handler)
{
char *buf;
char buf[24];
if (dm_asprintf(&buf, "%" PRIi32 ":%" PRIi32, major, minor) < 0)
stack;
if (!lvmetad_pv_gone(devno, buf ? : "", handler)) {
dm_free(buf);
return 0;
}
(void) dm_snprintf(buf, sizeof(buf), "%" PRIi32 ":%" PRIi32, major, minor);
if (!lvmetad_pv_gone(devno, buf, handler))
return_0;
log_print_unless_silent("Device %s not found. "
"Cleared from lvmetad cache.", buf ? : "");
dm_free(buf);
"Cleared from lvmetad cache.", buf);
return 1;
}