From 7b52a663a6436581cfacd9212929db551a00920f Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Wed, 10 May 2023 13:28:38 +0200 Subject: [PATCH] cov: validate dev_get_primary_dev result Make sure primary_dev is defined when using it. --- lib/device/dev-mpath.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/device/dev-mpath.c b/lib/device/dev-mpath.c index 5433b64e1..e6fc63afd 100644 --- a/lib/device/dev-mpath.c +++ b/lib/device/dev-mpath.c @@ -688,7 +688,8 @@ int dev_is_mpath_component(struct cmd_context *cmd, struct device *dev, dev_t *h * primary_result 2: dev is a partition, primary_dev is the whole device * primary_result 1: dev is a whole device */ - primary_result = dev_get_primary_dev(dt, dev, &primary_dev); + if (!(primary_result = dev_get_primary_dev(dt, dev, &primary_dev))) + return_0; if (_dev_is_mpath_component_sysfs(cmd, dev, primary_result, primary_dev, holder_devno) == 1) goto found;