From 7e135868374601020920094f135d678c688d0950 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Thu, 22 Apr 2021 12:30:26 +0200 Subject: [PATCH] cov: check _insert_dev return value Although we try later to validate device was inserted, we can validate return value and early-exit. --- lib/device/dev-cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/device/dev-cache.c b/lib/device/dev-cache.c index aa93b5758..dddf84e4d 100644 --- a/lib/device/dev-cache.c +++ b/lib/device/dev-cache.c @@ -1510,7 +1510,8 @@ struct device *dev_cache_get(struct cmd_context *cmd, const char *name, struct d * for st_rdev. */ if (!dev) { - _insert_dev(name, st.st_rdev); + if (!_insert_dev(name, st.st_rdev)) + return_NULL; /* Get the struct dev that was just added. */ dev = (struct device *) dm_hash_lookup(_cache.names, name);