From 837bfab75c712c28c161309f1381bb7a84eb17fb Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Thu, 26 Oct 2017 13:55:36 +0200 Subject: [PATCH] log: better message when reached log limit Add explaining message, when command was aborted due to the reach of configure line number count (LVM_LOG_FILE_MAX_LINES) for logging (used mainly with testing). --- lib/log/log.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index 8ca60e4f9..c0789b456 100644 --- a/lib/log/log.c +++ b/lib/log/log.c @@ -646,11 +646,16 @@ static void _vprint_log(int level, const char *file, int line, int dm_errno_or_c vfprintf(_log_file, trformat, ap); va_end(ap); + if (_log_file_max_lines && ++_log_file_lines >= _log_file_max_lines) { + fprintf(_log_file, "\n%s:%d %sAborting. Command has reached limit " + "for logged lines (LVM_LOG_FILE_MAX_LINES=" FMTu64 ").", + file, line, _msg_prefix, + _log_file_max_lines); + fatal_internal_error = 1; + } + fputc('\n', _log_file); fflush(_log_file); - - if (_log_file_max_lines && ++_log_file_lines >= _log_file_max_lines) - fatal_internal_error = 1; } if (_syslog && (_log_while_suspended || !critical_section())) {