shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

lvmlockd: check for multiple lock managers running

Browse Source 
When no lock manager for the global lock had been set yet,
and the first global lock request was received, and both
dlm and sanlock were running, lvmlockd would assume it
should use the dlm for the global lock, and would start
the "lvm_global" dlm lockspace automatically.  That's
not always correct, so don't assume the dlm should be used,
fail the lock request, and wait until a VG with a specific
lock type is started to determine the lock manager to use.
This commit is contained in:
David Teigland 2024-04-19 10:48:19 -05:00
parent f4911177da
commit 85b711caae
1 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
daemons/lvmlockd/lvmlockd-core.c
View File

@ -4154,12 +4154,26 @@ static int add_lock_action(struct action *act)
vg_ls_name(act->vg_name, ls_name);
} else {
if (!gl_use_dlm && !gl_use_sanlock && !gl_use_idm) {
if (lm_is_running_dlm())
int run_sanlock = lm_is_running_sanlock();
int run_dlm = lm_is_running_dlm();
int run_idm = lm_is_running_idm();
if (run_sanlock + run_dlm + run_idm >= 2) {
log_error("global lock op %s mode %s: multiple lock managers running sanlock=%d dlm=%d idm=%d",
op_str(act->op), mode_str(act->mode), run_sanlock, run_dlm, run_idm);
} else if (!run_sanlock && !run_dlm && !run_idm) {
log_debug("global lock op %s mode %s: no lock manager running",
op_str(act->op), mode_str(act->mode));
} else {
if (run_dlm)
gl_use_dlm = 1;
else if (lm_is_running_sanlock())
else if (run_sanlock)
gl_use_sanlock = 1;
else if (lm_is_running_idm())
else if (run_idm)
gl_use_idm = 1;
log_debug("global lock op %s mode %s: gl_use_sanlock %d gl_use_dlm %d gl_use_idm %d",
op_str(act->op), mode_str(act->mode), gl_use_sanlock, gl_use_dlm, gl_use_idm);
}
}
gl_ls_name(ls_name);
}