shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

libdm: do not read region before checking dms for NULL (Coverity)

Browse Source 
dm_stats_get_area_start() attempts to assign a region pointer from
a stats handle before checking it is non-NULL: move the assignment
after the test.
This commit is contained in:
Bryn M. Reeves 2015-08-17 18:25:22 +01:00
parent d1c65d1b28
commit 8967776713
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libdm/libdm-stats.c
View File

@ -1328,9 +1328,10 @@ int dm_stats_get_current_region_area_len(const struct dm_stats *dms,
int dm_stats_get_area_start(const struct dm_stats *dms, uint64_t *start, int dm_stats_get_area_start(const struct dm_stats *dms, uint64_t *start,
uint64_t region_id, uint64_t area_id) uint64_t region_id, uint64_t area_id)
{ {
struct dm_stats_region *region = &dms->regions[region_id]; struct dm_stats_region *region;
if (!dms || !dms->regions) if (!dms || !dms->regions)
return_0; return_0;
region = &dms->regions[region_id];
*start = region->start + region->step * area_id; *start = region->start + region->step * area_id;
return 1; return 1;
} }