From 8c72878cf2f53811cf5ae6fc9b7c787feb74e0c6 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Thu, 9 Mar 2017 17:09:31 +0100 Subject: [PATCH] pool: drop duplicated sign test Avoid duplicate testing of '-' sign. Already checked with arg_from_list_is_negative(). --- tools/toollib.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tools/toollib.c b/tools/toollib.c index f2951a79c..c10f5ca4f 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -1243,11 +1243,6 @@ int get_pool_params(struct cmd_context *cmd, } if (arg_is_set(cmd, poolmetadatasize_ARG)) { - if (arg_sign_value(cmd, poolmetadatasize_ARG, SIGN_NONE) == SIGN_MINUS) { - log_error("Negative pool metadata size is invalid."); - return 0; - } - if (arg_is_set(cmd, poolmetadata_ARG)) { log_error("Please specify either metadata logical volume or its size."); return 0;