shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

dev: be safer when reading sysfs properties

Browse Source 
Check if the value we read from sysfs is not blank and replace the '\n'
at the end only when needed ('\n' should usually be there for sysfs values,
but better check this).
This commit is contained in:
Peter Rajnoha 2016-03-21 15:48:36 +01:00
parent ca7bac53cf
commit 8fad9b9e5d
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/device/dev-cache.c
View File

@ -365,6 +365,7 @@ static int _add_alias(struct device *dev, const char *path)
static int _get_sysfs_value(const char *path, char *buf, size_t buf_size)
{
FILE *fp;
size_t len;
if (!(fp = fopen(path, "r"))) {
log_sys_error("fopen", path);
@ -378,7 +379,13 @@ static int _get_sysfs_value(const char *path, char *buf, size_t buf_size)
return 0;
}
buf[strlen(buf) - 1] = '\0';
if (!(len = strlen(buf))) {
log_error("_get_sysfs_value: %s: no value", path);
return 0;
}
if (buf[len - 1] == '\n')
buf[len - 1] = '\0';
if (fclose(fp))
log_sys_error("fclose", path);