shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

raid: add validation checks for reshape flags

Browse Source 
Enhance vg_validate() raid checking functions to check for
flags  LV_RESHAPE and LV_RESHAPE_DELTA_DISKS_(MINUS|PLUS).
This commit is contained in:
Heinz Mauelshagen 2017-11-15 21:24:44 +01:00
parent b0618f9011
commit 93c02e2532
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/metadata/merge.c
View File

@ -98,6 +98,14 @@ int lv_merge_segments(struct logical_volume *lv)
return; \
}
/* Check segment LV for reshape flags. */
static int _check_raid_seg_reshape_flags(struct lv_segment *seg)
{
return ((seg->lv->status & LV_RESHAPE) ||
(seg->lv->status & LV_RESHAPE_DELTA_DISKS_MINUS) ||
(seg->lv->status & LV_RESHAPE_DELTA_DISKS_PLUS));
}
/* Check raid0 segment properties in @seg */
static void _check_raid0_seg(struct lv_segment *seg, int *error_count)
{
@ -121,6 +129,8 @@ static void _check_raid0_seg(struct lv_segment *seg, int *error_count)
raid_seg_error_val("non-zero max recovery rate", seg->max_recovery_rate);
if ((seg->lv->status & LV_RESHAPE_DATA_OFFSET) || seg->data_offset > 1)
raid_seg_error_val("data_offset", seg->data_offset);
if (_check_raid_seg_reshape_flags(seg))
raid_seg_error("reshape");
}
/* Check RAID @seg for non-zero, power of 2 region size and min recovery rate <= max */
@ -145,6 +155,8 @@ static void _check_raid1_seg(struct lv_segment *seg, int *error_count)
raid_seg_error_val("non-zero stripe size", seg->stripe_size);
if ((seg->lv->status & LV_RESHAPE_DATA_OFFSET) || seg->data_offset > 1)
raid_seg_error_val("data_offset", seg->data_offset);
if (_check_raid_seg_reshape_flags(seg))
raid_seg_error("reshape");
_check_raid_region_recovery(seg, error_count);
}
@ -388,6 +400,9 @@ static void _check_lv_segment(struct logical_volume *lv, struct lv_segment *seg,
if (seg_is_raid(seg))
_check_raid_seg(seg, error_count);
else if (!lv_is_raid_type(lv) &&
_check_raid_seg_reshape_flags(seg))
seg_error("reshape");
if (seg_is_pool(seg)) {
if ((seg->area_count != 1) || (seg_type(seg, 0) != AREA_LV)) {