shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

cleanup: modules_needed only for devmapper

Browse Source 
Drop compilation of modules_needed and add_target_lin
function when compiled without devmapper support.
Cleanup surrounding ifdefs.
This commit is contained in:
Zdenek Kabelac 2014-04-29 23:41:17 +02:00
parent 62e8dd4f6e
commit 9401827919
7 changed files with 49 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
lib/cache_segtype/cache.c
View File

@ -216,35 +216,6 @@ static int _cache_pool_text_export(const struct lv_segment *seg,
return 1; return 1;
} }
static int _cache_pool_add_target_line(struct dev_manager *dm,
struct dm_pool *mem,
struct cmd_context *cmd __attribute__((unused)),
void **target_state __attribute__((unused)),
struct lv_segment *seg,
const struct lv_activate_opts *laopts __attribute__((unused)),
struct dm_tree_node *node, uint64_t len,
uint32_t *pvmove_mirror_count __attribute__((unused)))
{
/*
* This /could/ be directed at _cdata, but I prefer
* not to give a user direct access to a sub-LV via
* this cache_pool.
*/
return dm_tree_node_add_error_target(node, len);
}
static int _modules_needed(struct dm_pool *mem,
const struct lv_segment *seg __attribute__((unused)),
struct dm_list *modules)
{
if (!str_list_add(mem, modules, "cache")) {
log_error("cache module string list allocation failed");
return 0;
}
return 1;
}
static void _destroy(struct segment_type *segtype) static void _destroy(struct segment_type *segtype)
{ {
dm_free((void *) segtype); dm_free((void *) segtype);
@ -281,6 +252,17 @@ static int _target_present(struct cmd_context *cmd,
return _cache_present; return _cache_present;
} }
static int _modules_needed(struct dm_pool *mem,
const struct lv_segment *seg __attribute__((unused)),
struct dm_list *modules)
{
if (!str_list_add(mem, modules, "cache")) {
log_error("String list allocation failed for cache module.");
return 0;
}
return 1;
}
#endif /* DEVMAPPER_SUPPORT */ #endif /* DEVMAPPER_SUPPORT */
static struct segtype_handler _cache_pool_ops = { static struct segtype_handler _cache_pool_ops = {
@ -288,13 +270,12 @@ static struct segtype_handler _cache_pool_ops = {
.text_import = _cache_pool_text_import, .text_import = _cache_pool_text_import,
.text_import_area_count = _cache_pool_text_import_area_count, .text_import_area_count = _cache_pool_text_import_area_count,
.text_export = _cache_pool_text_export, .text_export = _cache_pool_text_export,
.add_target_line = _cache_pool_add_target_line,
#ifdef DEVMAPPER_SUPPORT #ifdef DEVMAPPER_SUPPORT
.target_present = _target_present, .target_present = _target_present,
.modules_needed = _modules_needed,
# ifdef DMEVENTD # ifdef DMEVENTD
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif #endif
.modules_needed = _modules_needed,
.destroy = _destroy, .destroy = _destroy,
}; };
@ -348,6 +329,7 @@ static int _cache_text_export(const struct lv_segment *seg, struct formatter *f)
return 1; return 1;
} }
#ifdef DEVMAPPER_SUPPORT
static int _cache_add_target_line(struct dev_manager *dm, static int _cache_add_target_line(struct dev_manager *dm,
struct dm_pool *mem, struct dm_pool *mem,
struct cmd_context *cmd __attribute__((unused)), struct cmd_context *cmd __attribute__((unused)),
@ -384,19 +366,20 @@ static int _cache_add_target_line(struct dev_manager *dm,
return add_areas_line(dm, seg, node, 0u, seg->area_count); return add_areas_line(dm, seg, node, 0u, seg->area_count);
} }
#endif /* DEVMAPPER_SUPPORT */
static struct segtype_handler _cache_ops = { static struct segtype_handler _cache_ops = {
.name = _name, .name = _name,
.text_import = _cache_text_import, .text_import = _cache_text_import,
.text_import_area_count = _cache_text_import_area_count, .text_import_area_count = _cache_text_import_area_count,
.text_export = _cache_text_export, .text_export = _cache_text_export,
.add_target_line = _cache_add_target_line,
#ifdef DEVMAPPER_SUPPORT #ifdef DEVMAPPER_SUPPORT
.add_target_line = _cache_add_target_line,
.target_present = _target_present, .target_present = _target_present,
.modules_needed = _modules_needed,
# ifdef DMEVENTD # ifdef DMEVENTD
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif #endif
.modules_needed = _modules_needed,
.destroy = _destroy, .destroy = _destroy,
}; };
@ -445,4 +428,3 @@ int init_cache_segtypes(struct cmd_context *cmd,
return 1; return 1;
} }

4
lib/error/errseg.c
View File

@ -63,7 +63,6 @@ static int _errseg_target_present(struct cmd_context *cmd,
_errseg_checked = 1; _errseg_checked = 1;
return _errseg_present; return _errseg_present;
} }
#endif
static int _errseg_modules_needed(struct dm_pool *mem, static int _errseg_modules_needed(struct dm_pool *mem,
const struct lv_segment *seg __attribute__((unused)), const struct lv_segment *seg __attribute__((unused)),
@ -76,6 +75,7 @@ static int _errseg_modules_needed(struct dm_pool *mem,
return 1; return 1;
} }
#endif
static void _errseg_destroy(struct segment_type *segtype) static void _errseg_destroy(struct segment_type *segtype)
{ {
@ -88,8 +88,8 @@ static struct segtype_handler _error_ops = {
#ifdef DEVMAPPER_SUPPORT #ifdef DEVMAPPER_SUPPORT
.add_target_line = _errseg_add_target_line, .add_target_line = _errseg_add_target_line,
.target_present = _errseg_target_present, .target_present = _errseg_target_present,
#endif
.modules_needed = _errseg_modules_needed, .modules_needed = _errseg_modules_needed,
#endif
.destroy = _errseg_destroy, .destroy = _errseg_destroy,
}; };

4
lib/mirror/mirrored.c
View File

@ -562,7 +562,6 @@ static int _target_unmonitor_events(struct lv_segment *seg, int events)
} }
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif /* DEVMAPPER_SUPPORT */
static int _mirrored_modules_needed(struct dm_pool *mem, static int _mirrored_modules_needed(struct dm_pool *mem,
const struct lv_segment *seg, const struct lv_segment *seg,
@ -585,6 +584,7 @@ static int _mirrored_modules_needed(struct dm_pool *mem,
return 1; return 1;
} }
#endif /* DEVMAPPER_SUPPORT */
static void _mirrored_destroy(struct segment_type *segtype) static void _mirrored_destroy(struct segment_type *segtype)
{ {
@ -602,13 +602,13 @@ static struct segtype_handler _mirrored_ops = {
.target_percent = _mirrored_target_percent, .target_percent = _mirrored_target_percent,
.target_present = _mirrored_target_present, .target_present = _mirrored_target_present,
.check_transient_status = _mirrored_transient_status, .check_transient_status = _mirrored_transient_status,
.modules_needed = _mirrored_modules_needed,
# ifdef DMEVENTD # ifdef DMEVENTD
.target_monitored = _target_registered, .target_monitored = _target_registered,
.target_monitor_events = _target_monitor_events, .target_monitor_events = _target_monitor_events,
.target_unmonitor_events = _target_unmonitor_events, .target_unmonitor_events = _target_unmonitor_events,
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif #endif
.modules_needed = _mirrored_modules_needed,
.destroy = _mirrored_destroy, .destroy = _mirrored_destroy,
}; };

29
lib/raid/raid.c
View File

@ -262,18 +262,6 @@ static int _raid_target_status_compatible(const char *type)
return (strstr(type, "raid") != NULL); return (strstr(type, "raid") != NULL);
} }
static int _raid_modules_needed(struct dm_pool *mem,
const struct lv_segment *seg __attribute__((unused)),
struct dm_list *modules)
{
if (!str_list_add(mem, modules, "raid")) {
log_error("raid module string list allocation failed");
return 0;
}
return 1;
}
static void _raid_destroy(struct segment_type *segtype) static void _raid_destroy(struct segment_type *segtype)
{ {
dm_free((void *) segtype); dm_free((void *) segtype);
@ -367,6 +355,18 @@ static int _raid_target_present(struct cmd_context *cmd,
return _raid_present; return _raid_present;
} }
static int _raid_modules_needed(struct dm_pool *mem,
const struct lv_segment *seg __attribute__((unused)),
struct dm_list *modules)
{
if (!str_list_add(mem, modules, "raid")) {
log_error("raid module string list allocation failed");
return 0;
}
return 1;
}
# ifdef DMEVENTD # ifdef DMEVENTD
static const char *_get_raid_dso_path(struct cmd_context *cmd) static const char *_get_raid_dso_path(struct cmd_context *cmd)
{ {
@ -399,8 +399,9 @@ static int _raid_target_unmonitor_events(struct lv_segment *seg, int events)
{ {
return _raid_set_events(seg, events, 0); return _raid_set_events(seg, events, 0);
} }
#endif /* DEVMAPPER_SUPPORT */
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif /* DEVMAPPER_SUPPORT */
static struct segtype_handler _raid_ops = { static struct segtype_handler _raid_ops = {
.name = _raid_name, .name = _raid_name,
.text_import_area_count = _raid_text_import_area_count, .text_import_area_count = _raid_text_import_area_count,
@ -411,13 +412,13 @@ static struct segtype_handler _raid_ops = {
#ifdef DEVMAPPER_SUPPORT #ifdef DEVMAPPER_SUPPORT
.target_percent = _raid_target_percent, .target_percent = _raid_target_percent,
.target_present = _raid_target_present, .target_present = _raid_target_present,
.modules_needed = _raid_modules_needed,
# ifdef DMEVENTD # ifdef DMEVENTD
.target_monitored = _raid_target_monitored, .target_monitored = _raid_target_monitored,
.target_monitor_events = _raid_target_monitor_events, .target_monitor_events = _raid_target_monitor_events,
.target_unmonitor_events = _raid_target_unmonitor_events, .target_unmonitor_events = _raid_target_unmonitor_events,
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif #endif
.modules_needed = _raid_modules_needed,
.destroy = _raid_destroy, .destroy = _raid_destroy,
}; };

8
lib/snapshot/snapshot.c
View File

@ -100,12 +100,12 @@ static int _snap_text_export(const struct lv_segment *seg, struct formatter *f)
return 1; return 1;
} }
#ifdef DEVMAPPER_SUPPORT
static int _snap_target_status_compatible(const char *type) static int _snap_target_status_compatible(const char *type)
{ {
return (strcmp(type, "snapshot-merge") == 0); return (strcmp(type, "snapshot-merge") == 0);
} }
#ifdef DEVMAPPER_SUPPORT
static int _snap_target_percent(void **target_state __attribute__((unused)), static int _snap_target_percent(void **target_state __attribute__((unused)),
percent_t *percent, percent_t *percent,
struct dm_pool *mem __attribute__((unused)), struct dm_pool *mem __attribute__((unused)),
@ -213,7 +213,6 @@ static int _target_unregister_events(struct lv_segment *seg,
} }
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif
static int _snap_modules_needed(struct dm_pool *mem, static int _snap_modules_needed(struct dm_pool *mem,
const struct lv_segment *seg __attribute__((unused)), const struct lv_segment *seg __attribute__((unused)),
@ -226,6 +225,7 @@ static int _snap_modules_needed(struct dm_pool *mem,
return 1; return 1;
} }
#endif /* DEVMAPPER_SUPPORT */
static void _snap_destroy(struct segment_type *segtype) static void _snap_destroy(struct segment_type *segtype)
{ {
@ -237,17 +237,17 @@ static struct segtype_handler _snapshot_ops = {
.target_name = _snap_target_name, .target_name = _snap_target_name,
.text_import = _snap_text_import, .text_import = _snap_text_import,
.text_export = _snap_text_export, .text_export = _snap_text_export,
.target_status_compatible = _snap_target_status_compatible,
#ifdef DEVMAPPER_SUPPORT #ifdef DEVMAPPER_SUPPORT
.target_status_compatible = _snap_target_status_compatible,
.target_percent = _snap_target_percent, .target_percent = _snap_target_percent,
.target_present = _snap_target_present, .target_present = _snap_target_present,
.modules_needed = _snap_modules_needed,
# ifdef DMEVENTD # ifdef DMEVENTD
.target_monitored = _target_registered, .target_monitored = _target_registered,
.target_monitor_events = _target_register_events, .target_monitor_events = _target_register_events,
.target_unmonitor_events = _target_unregister_events, .target_unmonitor_events = _target_unregister_events,
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif #endif
.modules_needed = _snap_modules_needed,
.destroy = _snap_destroy, .destroy = _snap_destroy,
}; };

4
lib/thin/thin.c
View File

@ -729,14 +729,12 @@ static struct segtype_handler _thin_pool_ops = {
.add_target_line = _thin_pool_add_target_line, .add_target_line = _thin_pool_add_target_line,
.target_percent = _thin_pool_target_percent, .target_percent = _thin_pool_target_percent,
.target_present = _thin_target_present, .target_present = _thin_target_present,
.modules_needed = _thin_pool_modules_needed,
# ifdef DMEVENTD # ifdef DMEVENTD
.target_monitored = _target_registered, .target_monitored = _target_registered,
.target_monitor_events = _target_register_events, .target_monitor_events = _target_register_events,
.target_unmonitor_events = _target_unregister_events, .target_unmonitor_events = _target_unregister_events,
# endif /* DMEVENTD */ # endif /* DMEVENTD */
#endif
#ifdef DEVMAPPER_SUPPORT
.modules_needed = _thin_pool_modules_needed,
#endif #endif
.destroy = _thin_destroy, .destroy = _thin_destroy,
}; };

4
lib/zero/zero.c
View File

@ -59,7 +59,6 @@ static int _zero_target_present(struct cmd_context *cmd,
return _zero_present; return _zero_present;
} }
#endif
static int _zero_modules_needed(struct dm_pool *mem, static int _zero_modules_needed(struct dm_pool *mem,
const struct lv_segment *seg __attribute__((unused)), const struct lv_segment *seg __attribute__((unused)),
@ -72,6 +71,7 @@ static int _zero_modules_needed(struct dm_pool *mem,
return 1; return 1;
} }
#endif
static void _zero_destroy(struct segment_type *segtype) static void _zero_destroy(struct segment_type *segtype)
{ {
@ -84,8 +84,8 @@ static struct segtype_handler _zero_ops = {
#ifdef DEVMAPPER_SUPPORT #ifdef DEVMAPPER_SUPPORT
.add_target_line = _zero_add_target_line, .add_target_line = _zero_add_target_line,
.target_present = _zero_target_present, .target_present = _zero_target_present,
#endif
.modules_needed = _zero_modules_needed, .modules_needed = _zero_modules_needed,
#endif
.destroy = _zero_destroy, .destroy = _zero_destroy,
}; };