From 960ee343f38471b0e41aed0a33442cba44cbc085 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Mon, 13 Feb 2012 10:58:20 +0000 Subject: [PATCH] Add missing test for failure of lvmcache_foreach_pv --- WHATS_NEW | 1 + lib/metadata/metadata.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/WHATS_NEW b/WHATS_NEW index 4fb2ebaaf..19674af62 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.92 - ==================================== + Check for foreach loop errors in _vg_read_orphans() (2.02.91). Clean error paths for format instance creation (2.02.91). Release vg in error path of _format1_vg_read() instead of just free(). Report allocation failure for allocation of PV structure. diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index af4f0342f..e3e3c37c2 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -2754,7 +2754,9 @@ static struct volume_group *_vg_read_orphans(struct cmd_context *cmd, baton.warnings = warnings; baton.vg = vg; - lvmcache_foreach_pv(vginfo, _vg_read_orphan_pv, &baton); + + if (!lvmcache_foreach_pv(vginfo, _vg_read_orphan_pv, &baton)) + return_NULL; return vg; }