shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

raid: better place for blocking reshapes

Browse Source 
Still the place can be better to block only particular reshape
operations which ATM cause kernel problems.

We check if the new number of images is higher - and prevent to take
conversion if the volume is in use (i.e. thin-pool's data LV).
This commit is contained in:
Zdenek Kabelac 2020-02-07 15:14:05 +01:00
parent ffea7daec3
commit 96985b1373
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/metadata/raid_manip.c
View File

@ -2298,6 +2298,13 @@ static int _raid_reshape(struct logical_volume *lv,
if ((new_image_count = new_stripes + seg->segtype->parity_devs) < 2) if ((new_image_count = new_stripes + seg->segtype->parity_devs) < 2)
return_0; return_0;
/* FIXME Can't reshape volume in use - aka not toplevel devices */
if (old_image_count < new_image_count &&
!dm_list_empty(&seg->lv->segs_using_this_lv)) {
log_error("Unable to convert stacked volume %s.", display_lvname(seg->lv));
return 0;
}
if (!_check_max_raid_devices(new_image_count)) if (!_check_max_raid_devices(new_image_count))
return_0; return_0;
@ -6216,12 +6223,6 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr
if (!(*segtype = get_segtype_from_flag(cmd, seg_flag))) if (!(*segtype = get_segtype_from_flag(cmd, seg_flag)))
return_0; return_0;
/* FIXME Can't reshape volume in use - aka not toplevel devices */
if (!dm_list_empty(&seg_from->lv->segs_using_this_lv)) {
log_error("Can't reshape stacked volume %s.", display_lvname(seg_from->lv));
return 0;
}
if (segtype_sav != *segtype) { if (segtype_sav != *segtype) {
log_warn("Replaced LV type %s%s with possible type %s.", log_warn("Replaced LV type %s%s with possible type %s.",
segtype_sav->name, _get_segtype_alias_str(seg_from->lv, segtype_sav), segtype_sav->name, _get_segtype_alias_str(seg_from->lv, segtype_sav),