1
0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00

systemd: lvm2-activation-generator: report only error otherwise be silent

Do not print success status for lvm2-activation-generator:

  "LVM: Activation generator successfully completed."
  "LVM: Logical Volume autoactivation enabled." (if use_lvmetad=1)

Though this information is quite useful during boot, it may
be confusing for users if it happens anytime later and it
actually happens if systemd reloads. This is usually on package
update to update the systemd state and load any new units that are
newly installed in the system. The systemd reload is global and
so any existing generators are rerun at that moment too.
This commit is contained in:
Peter Rajnoha 2013-08-22 08:14:11 +02:00
parent c8daa15270
commit 99fe3b88d2
2 changed files with 4 additions and 5 deletions

View File

@ -1,5 +1,6 @@
Version 2.02.101 -
===================================
Make lvm2-activation-generator silent unless it's in error state.
Remove "mpath major is not dm major" msg for mpath component scan (2.02.94).
Prevent cluster mirror logs from being corrupted by redundant checkpoints.
Fix ignored lvmetad update on loop device configuration (2.02.99).

View File

@ -180,10 +180,8 @@ int main(int argc, char *argv[])
}
/* If lvmetad used, rely on autoactivation instead of direct activation. */
if (lvm_uses_lvmetad()) {
kmsg(LOG_DEBUG, "LVM: Logical Volume autoactivation enabled.\n");
if (lvm_uses_lvmetad())
goto out;
}
dir = argc > 1 ? argv[1] : DEFAULT_UNIT_DIR;
@ -192,8 +190,8 @@ int main(int argc, char *argv[])
!generate_unit(dir, UNIT_NET))
r = EXIT_FAILURE;
out:
kmsg(r ? LOG_ERR : LOG_DEBUG, "LVM: Activation generator %s.\n",
r ? "failed" : "successfully completed");
if (r)
kmsg(LOG_ERR, "LVM: Activation generator failed.\n");
if (kmsg_fd != -1)
(void) close(kmsg_fd);
return r;