shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

Update error path tracing for _resume_node

Browse Source 
dm_task_create & dm_task_set_name produces it's own log_error
Add missing stacks for dm_task_set_cookie, dm_task_run,
dm_task_get_info.
This commit is contained in:
Zdenek Kabelac 2011-10-03 18:28:25 +00:00
parent 1419bf1c98
commit 9a8f192a38
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW_DM
View File

@ -1,5 +1,6 @@
Version 1.02.68 -
==================================
Update debug logging for _resume_node.
Add functions to support thin provisioning target (API unstable).
Improve libdm-config error path reporting.
Update dmsetup resume man with --addnodeonresume/create options.

19
libdm/libdm-deptree.c
View File

@ -1127,13 +1127,13 @@ static int _resume_node(const char *name, uint32_t major, uint32_t minor,
log_verbose("Resuming %s (%" PRIu32 ":%" PRIu32 ")", name, major, minor);
if (!(dmt = dm_task_create(DM_DEVICE_RESUME))) {
log_error("Suspend dm_task creation failed for %s", name);
log_debug("Suspend dm_task creation failed for %s.", name);
return 0;
}
/* FIXME Kernel should fill in name on return instead */
if (!dm_task_set_name(dmt, name)) {
log_error("Failed to set readahead device name for %s", name);
log_debug("Failed to set device name for %s resumption.", name);
goto out;
}
@ -1149,13 +1149,16 @@ static int _resume_node(const char *name, uint32_t major, uint32_t minor,
log_error("Failed to set read ahead");
if (!dm_task_set_cookie(dmt, cookie, udev_flags))
goto out;
goto_out;
if ((r = dm_task_run(dmt))) {
if (already_suspended)
dec_suspended();
r = dm_task_get_info(dmt, newinfo);
}
if (!(r = dm_task_run(dmt)))
goto_out;
if (already_suspended)
dec_suspended();
if (!(r = dm_task_get_info(dmt, newinfo)))
stack;
out:
dm_task_destroy(dmt);