shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-01-17 06:04:23 +03:00
Code Releases Activity

Reduce stack size usage in print_log

Browse Source 
As the buf2[] and locn[] can't be used at the same time, safe 1 page from
stack memory.
This commit is contained in:
Zdenek Kabelac 2011-10-22 16:52:00 +00:00
parent aef13649ea
commit 9e453cab1c
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
WHATS_NEW
View File

@ -1,5 +1,6 @@
Version 2.02.89 -
==================================
Remove extra 4kB buffer allocated on stack in print_log().
Make move_lv_segment non-static function and use dm_list function.
Pass exclusive LV locks to all nodes in the cluster.
Improve lvcreate man documentation of the chunksize option.

8
lib/log/log.c
View File

@ -185,7 +185,7 @@ void print_log(int level, const char *file, int line, int dm_errno,
const char *format, ...)
{
va_list ap;
char buf[1024], buf2[4096], locn[4096];
char buf[1024], locn[4096];
int bufused, n;
const char *message;
const char *trformat; /* Translated format string */
@ -221,7 +221,7 @@ void print_log(int level, const char *file, int line, int dm_errno,
(_store_errmsg && (level <= _LOG_ERR)) ||
log_once) {
va_start(ap, format);
n = vsnprintf(buf2, sizeof(buf2) - 1, trformat, ap);
n = vsnprintf(locn, sizeof(locn) - 1, trformat, ap);
va_end(ap);
if (n < 0) {
@ -230,8 +230,8 @@ void print_log(int level, const char *file, int line, int dm_errno,
goto log_it;
}
buf2[sizeof(buf2) - 1] = '\0';
message = &buf2[0];
locn[sizeof(locn) - 1] = '\0';
message = &locn[0];
}
/* FIXME Avoid pointless use of message buffer when it'll never be read! */