shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-02-25 21:57:45 +03:00
Code Releases Activity

pvscan: fix segfault in recent commit

Browse Source 
commit aa75b31db5478
  "pvscan: handle case of scanning PV without metadata last"

failed to recognize that an arg may be null in the case of
'pvscan --cache' (without -aay) which does not keep track
of complete VGs because it does not need to activate them.
This commit is contained in:
David Teigland 2019-05-03 16:51:34 -05:00
parent 3405ead1e0
commit 9f561f2206
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/pvscan.c
View File

@ -759,6 +759,10 @@ static void _check_vg_with_pvid_complete(struct cmd_context *cmd,
*
* . When dev_args is set, then complete VGs that that contain
* devs in dev_args will be returned in found_vgnames.
*
* found_vgnames is null for 'pvscan --cache' (without -aay)
* since the command does not need to keep track of complete
* vgs since it does not need to activate them.
*/
static void _online_pvscan_all_devs(struct cmd_context *cmd,
@ -794,7 +798,7 @@ static void _online_pvscan_all_devs(struct cmd_context *cmd,
}
/* This PV without metadata may complete a VG. */
if (pvid_without_metadata)
if (pvid_without_metadata && found_vgnames)
_check_vg_with_pvid_complete(cmd, found_vgnames, &all_vgs, pvid_without_metadata);
}