shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

lvconvert: Disallow mixing of cache and thin pools.

Browse Source 
--cachepool can't take a thin pool and --thinpool can't take a
cache pool.
This commit is contained in:
Alasdair G Kergon 2014-09-17 17:11:01 +01:00
parent bdb05cc05e
commit a2a869afc8
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/lvconvert.c
View File

@ -2733,6 +2733,18 @@ static int _lvconvert_pool(struct cmd_context *cmd,
if (lv_is_pool(pool_lv)) {
lp->pool_data_lv = pool_lv;
if (arg_is_set(cmd, cachepool_ARG) && lv_is_thin_pool(pool_lv)) {
log_error("--cachepool requires a cache pool. %s is a thin pool.",
display_lvname(pool_lv));
return 0;
}
if (arg_is_set(cmd, thinpool_ARG) && lv_is_cache_pool(pool_lv)) {
log_error("--thinpool requires a thin pool. %s is a cache pool.",
display_lvname(pool_lv));
return 0;
}
if (!metadata_lv) {
if (arg_from_list_is_set(cmd, "is invalid with existing pool",
cachemode_ARG,chunksize_ARG, discards_ARG,