shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2024-12-21 13:34:40 +03:00
Code Releases Activity

lvresize: improve usepolices

Browse Source 
lvresize --usepolicy requires resized LVs to be active.
(So it's not only required for shared VG).

The test for active pool needs to use lv_info to query 'layer'
otherwise the pool is considered inactive if it was not activated
explicitely - thun 'implicit' activation with VDO or ThinLV was
not managed by --usepolicy option.
This commit is contained in:
Zdenek Kabelac 2023-07-14 16:13:41 +02:00
parent 8cbba1d164
commit a2b2ae35b2
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tools/lvresize.c
View File

@ -259,29 +259,22 @@ out:
static int _lv_extend_policy(struct cmd_context *cmd, struct logical_volume *lv, static int _lv_extend_policy(struct cmd_context *cmd, struct logical_volume *lv,
struct lvresize_params *lp, int *skipped) struct lvresize_params *lp, int *skipped)
{ {
struct lvresize_params lp_meta;
uint32_t percent_main = 0; uint32_t percent_main = 0;
uint32_t percent_meta = 0; uint32_t percent_meta = 0;
int is_active; int is_active;
memset(&lp_meta, 0, sizeof(lp_meta)); if (lv_is_cow(lv))
is_active = lv_is_active(lv);
if (!lv_is_cow(lv) && !lv_is_thin_pool(lv) && !lv_is_vdo_pool(lv)) { else if (lv_is_thin_pool(lv) || lv_is_vdo_pool(lv))
/* check for -layer active LV */
is_active = lv_info(lv->vg->cmd, lv, 1, NULL, 0, 0);
else {
log_error("lvextend policy is supported only for snapshot, thin pool and vdo pool volumes."); log_error("lvextend policy is supported only for snapshot, thin pool and vdo pool volumes.");
*skipped = 1;
return 0; return 0;
} }
is_active = lv_is_active(lv); if (!is_active) {
log_error("lvextend using policy requires the volume to be active.");
if (vg_is_shared(lv->vg) && !is_active) {
log_debug("lvextend policy requires LV to be active in a shared VG.");
*skipped = 1;
return 1;
}
if (lv_is_thin_pool(lv) && !is_active) {
log_error("lvextend using policy requires the thin pool to be active.");
return 0; return 0;
} }