shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

vdo: add reformating to extent size aligned virtual size

Browse Source 
Newer VDO kernel target require to have matching virtual size - this
however cause incompatiblity when lvcreate is let to format VDO data
device and read the usable size from vdoformat.
Altough this is a kernel regression and will likely get fixed,
lvm2 can actually reformat VDO device to use properly aligned VDO LV
size to make this problem disappear.
This commit is contained in:
Zdenek Kabelac 2022-07-09 00:42:01 +02:00
parent ebad057579
commit a477490e81
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/metadata/vdo_manip.c
View File

@ -227,10 +227,11 @@ static int _format_vdo_pool_data_lv(struct logical_volume *data_lv,
const struct dm_vdo_target_params *vtp, const struct dm_vdo_target_params *vtp,
uint64_t *logical_size) uint64_t *logical_size)
{ {
char *dpath; char *dpath, *c;
const struct dm_config_node *cn; const struct dm_config_node *cn;
const struct dm_config_value *cv; const struct dm_config_value *cv;
struct pipe_data pdata; struct pipe_data pdata;
uint64_t logical_size_aligned = 1;
FILE *f; FILE *f;
uint64_t lb; uint64_t lb;
unsigned slabbits; unsigned slabbits;
@ -247,7 +248,9 @@ static int _format_vdo_pool_data_lv(struct logical_volume *data_lv,
return 0; return 0;
} }
reformat:
if (*logical_size) { if (*logical_size) {
logical_size_aligned = 0;
if (dm_snprintf(buf_args[args], sizeof(buf_args[0]), "--logical-size=" FMTu64 "K", if (dm_snprintf(buf_args[args], sizeof(buf_args[0]), "--logical-size=" FMTu64 "K",
(*logical_size / 2)) < 0) (*logical_size / 2)) < 0)
return_0; return_0;
@ -332,8 +335,8 @@ static int _format_vdo_pool_data_lv(struct logical_volume *data_lv,
log_verbose("Available VDO logical blocks " FMTu64 " (%s).", log_verbose("Available VDO logical blocks " FMTu64 " (%s).",
lb, display_size(data_lv->vg->cmd, *logical_size)); lb, display_size(data_lv->vg->cmd, *logical_size));
} }
if ((dpath = strchr(buf, '\n'))) if ((c = strchr(buf, '\n')))
*dpath = 0; /* cut last '\n' away */ *c = 0; /* cut last '\n' away */
if (buf[0]) if (buf[0])
log_print(" %s", buf); /* Print vdo_format messages */ log_print(" %s", buf); /* Print vdo_format messages */
} }
@ -348,6 +351,19 @@ static int _format_vdo_pool_data_lv(struct logical_volume *data_lv,
return 0; return 0;
} }
if (logical_size_aligned) {
// align obtained size to extent size
logical_size_aligned = *logical_size / data_lv->vg->extent_size * data_lv->vg->extent_size;
if (*logical_size != logical_size_aligned) {
*logical_size = logical_size_aligned;
argv[1] = (char*) "--force";
args = 2;
log_verbose("Reformating VDO to align virtual size %s by extent size.",
display_size(data_lv->vg->cmd, *logical_size));
goto reformat;
}
}
return 1; return 1;
} }