diff --git a/tools/lvcreate.c b/tools/lvcreate.c index 9d035b8cb..9c6150cef 100644 --- a/tools/lvcreate.c +++ b/tools/lvcreate.c @@ -789,9 +789,6 @@ static int _lvcreate_params(struct lvcreate_params *lp, return 0; } - if (!_read_activation_params(lp, cmd)) - return_0; - /* * Allocation parameters */ @@ -993,6 +990,15 @@ int lvcreate(struct cmd_context *cmd, int argc, char **argv) goto_out; } + /* + * Check activation parameters to support inactive thin snapshot creation + * FIXME: anything else needs to be moved past _determine_snapshot_type()? + */ + if (!_read_activation_params(&lp, cmd)) { + r = ECMD_FAILED; + goto_out; + } + if (!_update_extents_params(vg, &lp, &lcp)) { r = ECMD_FAILED; goto_out;