From a7101e7bfb1b8f5f792974a3b5f39fa4fcdb5656 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Fri, 10 Jul 2015 13:51:15 +0200 Subject: [PATCH] cleanup: drop duplicated seg test Test is already in seg_is_pool() if branch. and one minor indent fix. --- lib/metadata/merge.c | 3 +-- tools/lvcreate.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/metadata/merge.c b/lib/metadata/merge.c index 530b4e439..e38cb5336 100644 --- a/lib/metadata/merge.c +++ b/lib/metadata/merge.c @@ -237,8 +237,7 @@ int check_lv_segments(struct logical_volume *lv, int complete_vg) inc_error_count; } - if (seg_is_pool(seg) && - !validate_pool_chunk_size(lv->vg->cmd, seg->segtype, seg->chunk_size)) { + if (!validate_pool_chunk_size(lv->vg->cmd, seg->segtype, seg->chunk_size)) { log_error("LV %s: %s segment %u has invalid chunk size %u.", lv->name, seg->segtype->name, seg_count, seg->chunk_size); inc_error_count; diff --git a/tools/lvcreate.c b/tools/lvcreate.c index 259513077..12b5166db 100644 --- a/tools/lvcreate.c +++ b/tools/lvcreate.c @@ -587,7 +587,7 @@ static int _read_cache_params(struct cmd_context *cmd, } static int _read_activation_params(struct cmd_context *cmd, - struct volume_group *vg, + struct volume_group *vg, struct lvcreate_params *lp) { unsigned pagesize = lvm_getpagesize() >> SECTOR_SHIFT;