diff --git a/libdm/libdm-deptree.c b/libdm/libdm-deptree.c index fad14d64a..e51388510 100644 --- a/libdm/libdm-deptree.c +++ b/libdm/libdm-deptree.c @@ -1626,7 +1626,9 @@ static int _dm_tree_deactivate_children(struct dm_tree_node *dnode, info.minor); r = 0; continue; - } else if (info.suspended && info.live_table) + } + + if (info.suspended && info.live_table) dec_suspended(); if (child->callback && @@ -2705,7 +2707,7 @@ int dm_tree_preload_children(struct dm_tree_node *dnode, child->info.minor); /* If the device was not previously active, we might as well remove this node. */ if (!child->info.live_table && - !_deactivate_node(child->name, child->info.major,child->info.minor, + !_deactivate_node(child->name, child->info.major, child->info.minor, &child->dtree->cookie, child->udev_flags, 0)) log_error("Unable to deactivate %s (%" PRIu32 ":%" PRIu32 ")", child->name, child->info.major, diff --git a/tools/lvconvert.c b/tools/lvconvert.c index 814ac65bc..09a64c775 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -3134,6 +3134,7 @@ static int _poll_logical_volume(struct cmd_context *cmd, struct logical_volume * log_print_unless_silent("Conversion starts after activation."); return ECMD_PROCESSED; } + return lvconvert_poll(cmd, lv, wait_completion ? 0 : 1U); } diff --git a/tools/toollib.c b/tools/toollib.c index 31033e613..91b05594e 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -681,7 +681,7 @@ int process_each_vg(struct cmd_context *cmd, int argc, char **argv, if (sigint_caught()) return_ECMD_FAILED; vgid = sl->str; - if (!(vgid) || !(vg_name = lvmcache_vgname_from_vgid(cmd->mem, vgid))) + if (!vgid || !(vg_name = lvmcache_vgname_from_vgid(cmd->mem, vgid))) continue; ret_max = _process_one_vg(cmd, vg_name, vgid, &tagsl, &arg_vgnames,