shaba/lvm2
1
0
Fork 0
mirror of git://sourceware.org/git/lvm2.git synced 2025-03-10 16:58:47 +03:00
Code Releases Activity

FIXMEs to note problems with some error paths. (Perhaps safer to disable

Browse Source 
them until they can be fixed completely?)
This commit is contained in:
Alasdair Kergon 2011-09-21 16:36:39 +00:00
parent f5d39ec97a
commit a944480b9b
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/pvmove.c
View File

@ -365,6 +365,7 @@ static int _update_metadata(struct cmd_context *cmd, struct volume_group *vg,
}
if (!_suspend_lvs(cmd, first_time, lv_mirr, lvs_changed)) {
/* FIXME vg_revert must be moved *before* any LV resumes */
vg_revert(vg);
goto_out;
}
@ -388,13 +389,16 @@ static int _update_metadata(struct cmd_context *cmd, struct volume_group *vg,
/*
* Nothing changed yet, try to revert pvmove.
* FIXME This error path is incomplete and unsafe.
*/
log_error("Temporary pvmove mirror activation failed.");
/* Ensure that temporary mrror is deactivate even on other nodes. */
/* FIXME Unsafe to proceed if this fails without checking explicitly that no pvmove LVs are still active */
(void)deactivate_lv(cmd, lv_mirr);
/* Revert metadata */
/* FIXME Use --abort code instead? */
if (!_detach_pvmove_mirror(cmd, lv_mirr) ||
!lv_remove(lv_mirr) ||
!vg_write(vg) || !vg_commit(vg))