From a9a7c297aebe82ddc9092b7b19cc9cfcc27e117e Mon Sep 17 00:00:00 2001 From: Peter Rajnoha Date: Thu, 9 Jul 2015 13:11:57 +0200 Subject: [PATCH] coverity: missing return value for dm_split_lvm_name pass proper DM name instead of NULL value --- daemons/lvmlockd/lvmlockd-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/daemons/lvmlockd/lvmlockd-core.c b/daemons/lvmlockd/lvmlockd-core.c index ff5510c0e..eee1da1e0 100644 --- a/daemons/lvmlockd/lvmlockd-core.c +++ b/daemons/lvmlockd/lvmlockd-core.c @@ -4726,7 +4726,10 @@ static int remove_inactive_lvs(struct list_head *vg_lockd) strncpy(namebuf, names->name, MAX_NAME); vgname = namebuf; - dm_split_lvm_name(NULL, NULL, &vgname, &lvname, &layer); + if (!dm_split_lvm_name(NULL, namebuf, &vgname, &lvname, &layer)) { + log_error("failed to split dm name %s", namebuf); + goto next_dmname; + } log_debug("adopt remove_inactive dm name %s dm uuid %s vgname %s lvname %s", names->name, dm_uuid, vgname, lvname);